Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Ignition distribution to Edifice #307

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Bump Ignition distribution to Edifice #307

merged 5 commits into from
Apr 1, 2021
+98 −17

Conversation

diegoferigo
Copy link
Collaborator

@diegoferigo diegoferigo commented Mar 26, 2021 •
edited
Loading

  • Update CMake logic
  • Update CI to:
    • Build and test gym-ignition against Edifice
    • Build and upload wheels by default against Edifice
    • Build docker images with Edifice
  • Check that all documentation is updated
  • Check that building the wheel locally succeeds by passing custom Dome flag to pip / setup.py (even if not supported officially)
  • Mark the new workflow Build and Test (<New Ignition Distribution>) check as Required in the branches setting

@diegoferigo diegoferigo self-assigned this Mar 26, 2021
@diegoferigo diegoferigo linked an issue Mar 26, 2021 that may be closed by this pull request
Planned upgrade to Edifice #306
Closed
@diegoferigo
Copy link
Collaborator Author

Currently CI fails after building Ignition Edifice and gym-ignition in the tests with the following error:

Traceback:
/usr/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
__init__.py:5: in <module>
    from . import common
common/__init__.py:5: in <module>
    from . import utils
common/utils.py:8: in <module>
    from gym_ignition.utils import misc
../python/gym_ignition/__init__.py:12: in <module>
    from gym_ignition.utils import resource_finder
../python/gym_ignition/utils/__init__.py:5: in <module>
    from . import math
../python/gym_ignition/utils/math.py:8: in <module>
    from scenario import gazebo as scenario
/usr/lib/python3/dist-packages/scenario/__init__.py:130: in <module>
    from .bindings import core
/usr/lib/python3/dist-packages/scenario/bindings/core.py:12: in <module>
    import scenario.bindings.gazebo
/usr/lib/python3/dist-packages/scenario/bindings/gazebo.py:13: in <module>
    from . import _gazebo
E   ImportError: libignition-plugin1-loader.so.1: cannot open shared object file: No such file or directory

It seems that the runtime shared library libignition-plugin1-loader.so.1 is not found by the dynamic loader.

@diegoferigo diegoferigo mentioned this pull request Mar 26, 2021
Closed
@diegoferigo
Copy link
Collaborator Author

It seems that the runtime shared library libignition-plugin1-loader.so.1 is not found by the dynamic loader.

Fixed by 2771aaa

This was referenced Mar 29, 2021
Merged
Closed
Closed
@diegoferigo diegoferigo force-pushed the feature/edifice branch 3 times, most recently from c37d1c7 to c9cea97 Compare March 31, 2021 16:20
@diegoferigo diegoferigo mentioned this pull request Mar 31, 2021
Merged
@diegoferigo diegoferigo mentioned this pull request Apr 1, 2021
Merged
@diegoferigo diegoferigo marked this pull request as ready for review April 1, 2021 13:23
@diegoferigo diegoferigo requested a review from traversaro April 1, 2021 13:23
@diegoferigo
Copy link
Collaborator Author

I'll merge this PR right after tagging the next release (1.2.0) that will be still compatible with Dome.

@diegoferigo
Use interactive bash session also when calling pytest
eee866d 
Otherwise the environment does not source the setup.sh script of Ignition
@diegoferigo diegoferigo merged commit b5db6d3 into devel Apr 1, 2021
@diegoferigo diegoferigo deleted the feature/edifice branch April 1, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@diegoferigo diegoferigo

Labels
complexity::low component::cicd component::cmake component:documentation pr::resolution::merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planned upgrade to Edifice
2 participants
@diegoferigo @traversaro